Fix FileDialog when saving world #3110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
ahcorde
approved these changes
Oct 14, 2025
|
@Mergifyio backport gz-sim10 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 097c9a5)
9 tasks
iche033
added a commit
that referenced
this pull request
Oct 15, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 097c9a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3109
Summary
Currently with the
FileDialog.OpenFilefile mode, users can only save the world sdf to an existing file. This PR changes the file mode toFileDilaog.SaveFileso that users can create a new file to save.This textfield for naming a new file should now be available in the file dialog. On ubuntu, this will appear at the top of the dialog:
Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.